Add moveLayer operation to diffStyles
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
_From @anandthakker on November 17, 2016 18:50_
Currently, when a layer is moved, diffStyles produces a `removeLayer`/`addLayer` pair. Replacing this with `moveLayer` would better enable the use of the `{Map,Style}#moveLayer` methods in GL JS ( See also https://github.com/mapbox/mapbox-gl-js/issues/3649 )
_Copied from original issue: mapbox/mapbox-gl-style-spec#577_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating the diffStyles entry point and tracing how layer order changes currently become removeLayer/addLayer operations. Compare the expected operation with the Map and Style moveLayer methods in GL JS; done means moved layers produce moveLayer while other changes retain their existing operations, with coverage for the changed diff.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100