mapbox / mapbox/mapbox-gl-js

Validation should enforce "requires"

Open
#4,129 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cross-platform :tv:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

_From @jfirebaugh on September 20, 2016 20:19_

The style specification has various properties with `requires` values that specify constraints on related properties. These constraints should be enforced by the validator.

This makes validation stricter, so we will have to be cautious about rolling out enforcement.

_Copied from original issue: mapbox/mapbox-gl-style-spec#499_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names the style specification's `requires` values and the validator, but no files or tests. Start by locating the style-spec validation code and its handling of related-property constraints. Done means those `requires` constraints are enforced, with the stricter rollout considered before enabling it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
tooling
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.