Add a maximum for "text-offset" to avoid overflows
Open
Nobody has claimed this yet.
cross-platform :tv:
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
From @mourner on August 17, 2016 18:54
Let's validate text-offset values so that any values > 18 throw an error.
Will resolve https://github.com/mapbox/mapbox-gl-js/issues/3005.
Copied from original issue: mapbox/mapbox-gl-style-spec#481
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the validation path for the text-offset style property and inspect how numeric bounds are tested. Add coverage for values greater than 18 and confirm that they produce an error, resolving the overflow issue described here.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100