Increase flexibility of collision detection options
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
_From @ansis on March 18, 2016 0:53_
There are currently two properties that affect how a symbol
- `-allow-overlap` determines if previous symbols affect the placement of the current symbol
- `-ignore-placement` determines if the current symbol will affect the placement of layer symbols
In most cases you want both to have the same value. I can't think of an example you would want them to be different.
**We should remove -ignore-placement and make -allow-overlap do what both these properties currently do.**
@nickidlugash @peterqliu can you imagine a case where you would want these two properties to be separate?
_Copied from original issue: mapbox/mapbox-gl-style-spec#429_
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace the definitions and usages of -allow-overlap and -ignore-placement, beginning with the collision-detection behavior described in the issue. Confirm whether any callers require different values, then unify the behavior under -allow-overlap, remove -ignore-placement, and update the relevant tests and style specification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 35/100