mapbox / mapbox/mapbox-gl-js

Validation errors for layer properties should include layer id

Open
#4,108 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

cross-platform :tv:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

From @jfirebaugh on February 12, 2016 19:35

Current message:

Error: layers[101].layout.icon-image.stops[1][0]: array stops must appear in ascending order and have no duplicates

This would be more helpful:

Error: Layer "major-road-casing", layout.icon-image.stops[1][0]: array stops must appear in ascending order and have no duplicates

Copied from original issue: mapbox/mapbox-gl-style-spec#417

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Locate the layer-property validation entry point and compare the current and requested error formats; done means validation errors identify the layer by name and retain the existing property path and explanation.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.