mapbox / mapbox/mapbox-gl-js

Change the default of "icon-allow-overlap" and "text-allow-overlap" to true

Open
#4,106 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change :warning: cross-platform :tv:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

_From @lucaswoj on January 27, 2016 22:56_

I've seen more than one user be confused about why their overlapping symbols are not showing up on the map by default. https://github.com/mapbox/mapbox-gl-js/issues/2005

We should change the default value for `icon-allow-overlap` and `text-allow-overlap` to true.

It'd be an breaking change but mitigated by the migration script.

_Copied from original issue: mapbox/mapbox-gl-style-spec#405_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the style-spec definitions for `icon-allow-overlap` and `text-allow-overlap`, then inspect the migration script mentioned in the issue. Confirm how the existing issue about overlapping symbols is covered and verify that both defaults become true while the breaking change remains handled by migration.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.