mapbox / mapbox/mapbox-gl-js

Remove "fill-antialias" property

Open
#4,093 7 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change :warning: cross-platform :tv:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

_From @ansis on June 11, 2015 19:39_

`fill-antialias` is useless. Theoretically you could disable antialiasing to get a tiny performance improvement if the fill edges are covered by something else (a thick line outline). In practice the performance improvement is insignificant.

_Copied from original issue: mapbox/mapbox-gl-style-spec#289_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No file or test is named in the issue. Search the repository for references to the `fill-antialias` property, trace where the style property is defined and consumed, and review related tests before removing its support. Done means the property is no longer accepted or used and the affected tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.