mapbox / mapbox/mapbox-gl-js

Remove `miter-limit` and `round-limit`?

Open
#4,092 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change :warning: cross-platform :tv:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

_From @nickidlugash on June 10, 2015 17:36_

Per random conversation with @ansis and @kkaefer: should we remove these two properties for v8? Has anyone actually ever used them? In theory these are useful, but in practice, the default values work well enough that I've never, ever changed them.

@samanpwbb @peterqliu @andreasviglakis have you ever come across joints in geometries that are extreme enough to want to adjust these properties?

/cc @mayagao

_Copied from original issue: mapbox/mapbox-gl-style-spec#286_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the discussion about `miter-limit` and `round-limit`, including whether anyone relies on them for extreme geometry joints. Then locate where these properties are defined, validated, documented, and consumed; the work is done when the project has a decided v8 behavior and all affected references are consistently updated.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.