mapbox / mapbox/mapbox-gl-js

Provide "fill-stroke-*" properties and rename "fill" to "polygon"

Open
#4,087 23 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

breaking change :warning: cross-platform :tv: feature :green_apple:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

_From @jfirebaugh on November 21, 2014 3:46_

Pros:
- An SVG-like "polygon" type layer that supports both stroke and fill is how style authors expect and want things to work (see e.g. #221, #217, #218)
- `fill-outline-color` is a hack (#199)

Cons:
- Performance concerns?

_Copied from original issue: mapbox/mapbox-gl-style-spec#223_

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files, tests, or entry points. Start by locating the style-spec implementation and existing fill and fill-outline-color properties; done means supporting the proposed fill-stroke-* properties and the fill-to-polygon rename without unresolved behavior or compatibility questions.

Written by the indexing model from the issue text.

Assessment

Domain
frontend
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.