mapbox / mapbox/mapbox-gl-js

Add integration tests for "line-offset" on polygons

Open
#3,918 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

testing :100:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Migrated from https://github.com/mapbox/mapbox-gl-test-suite/issues/124

> Refs https://github.com/mapbox/mapbox-gl-js/issues/2889
>
> Test:
> - Vector tile polygon
> - GeoJSON polygon with correct winding order
> - GeoJSON polygon with incorrect winding order

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the referenced mapbox-gl-test-suite issue 124 and mapbox-gl-js issue 2889 to understand the expected line-offset behavior, then locate the existing integration tests for polygon rendering. Add coverage for vector-tile polygons and GeoJSON polygons with correct and incorrect winding order; done means all three cases are exercised.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
testing, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.