mapbox / mapbox/mapbox-gl-js

Severe line-offset artifacts with non-miter joins

Open
#3,809 4 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

![offset-yum](https://cloud.githubusercontent.com/assets/58878/21209070/1bedc03c-c240-11e6-9bc2-6a2c0e7076e5.gif)

**mapbox-gl-js version 0.28.0**

### Steps to Trigger Behavior

1. set line-offset to > 0
2. set line-round-limit to 1

### Expected Behavior

Nicely rendered lines

### Actual Behavior

Very artifacty lines.

---

Similar to https://github.com/mapbox/mapbox-gl-js/issues/2316, but applies with any line-join.

cc @lucaswoj @jfirebaugh @pveugen

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in mapbox-gl-js 0.28.0 using a positive line-offset and line-round-limit set to 1, then compare the rendering with the expected artifact-free result. Trace the line rendering entry point for these properties and investigate the behavior across the different line-join settings. Done means the reported artifacts no longer appear under the stated conditions.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.