mapbox / mapbox/mapbox-gl-js

Add Style#setGlyphs method

Open
#3,625 2 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature :green_apple:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Follows on to #3621: add setGlyphs and setSprite methods so that smart setStyle does not have to bail out and recreate the whole style when these properties change.

update: See also #2058

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reading the Style#setStyle behavior described here and follow the context in issues #3621 and #2058. Trace how smart setStyle handles changing glyphs and determine what must be exposed for setGlyphs to avoid recreating the whole style; done means glyph changes update the existing style path without that fallback.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.