mapbox / mapbox/mapbox-gl-js

Add fitFeature method

Open
#2,245 4 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

feature :green_apple: GL native → GL JS
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

"bounds" is an ill-defined concept in mapbox-gl-js due to pitch and rotation. A less ambiguous and more useful API would fit the map to an arbitrary GeoJSON feature.

ref https://github.com/mapbox/mapbox-gl-js/issues/2112

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read the referenced issue #2112 first to understand the ambiguity around bounds, pitch, and rotation. Then inspect the existing map camera and GeoJSON-related APIs; done means defining and implementing a fitFeature API that fits an arbitrary GeoJSON feature without relying on the ill-defined bounds concept.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.