Calling geojson.updateData multiple times in a short period of time can cause data loss
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
Especially when deleting.
I have three features to be deleted;
Now I call `geojson.updateData` 3 times in a row, the second one may not be deleted.
I checked the source code and found that `updateData` directly overwrites `_data`. If the previous `_updateWorkerData` is not completed, will some of the data that should be changed be lost if it is called multiple times in succession?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at geojson.updateData and inspect how _data is overwritten while _updateWorkerData is pending. Reproduce the three successive deletions and determine whether each update is retained; done means no feature deletion is lost when updates are called in a short sequence.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 35/100