mapbox / mapbox/mapbox-gl-js

Support models without Draco compression in Model layer

Open
#13,106 0 comments 0 reactions 0 assignees View on GitHub
3d :triangular_ruler: bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

When adding models without Draco compression to model layer (v3.2.0), the models don't show up well:

Demo: https://bertt.github.io/mapbox_issues/draco/no_draco/

![image](https://github.com/mapbox/mapbox-gl-js/assets/538812/50669e06-6283-4b71-9dcf-85995a76fcce)

Workaround is to add Draco compression: https://bertt.github.io/mapbox_issues/draco/with_draco/

![image](https://github.com/mapbox/mapbox-gl-js/assets/538812/a9ecad15-fa6f-46a0-b03b-7588b739f118)

Request: Check in model layer if models have Draco compression or not

Contributor guide

Open the contributing guide

Research direction

Start by comparing the no-Draco and with-Draco demo URLs to reproduce the model-layer rendering difference. Then locate the model-layer handling involved in loading these assets and determine how completion should be verified for models both with and without Draco compression.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.