mapbox / mapbox/mapbox-gl-js

3D building light emission bug with terrain turned on

Open
#12,875 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Enabling terrain with the new 3d models with lighting creates a strange effect where the light appears much higher than the actual model, floating in the sky.

**3.0.0-pre1**:

**firefox**:

### Steps to Trigger Behavior

Enable Terrain on the new standard style, `exaggeration: 1`

### Terrain turned off:
![image](https://github.com/mapbox/mapbox-gl-js/assets/54665621/65f42855-d99a-46b4-8c81-4c79924d4b7c)

### Terrain turned on:
![image](https://github.com/mapbox/mapbox-gl-js/assets/54665621/28a317c6-6f73-4d14-95c5-6bcc000cd94c)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue in Firefox with terrain enabled, the new standard style, 3D models, and exaggeration 1, comparing terrain off and on. The issue names no source files or tests, so first locate the terrain, model-lighting, and rendering entry points; done means the light remains aligned with the model when terrain is enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.