mapbox / mapbox/mapbox-gl-js

Applying too much bottom padding in globe projection renders a circle around the globe

Open
#12,636 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

After applying enough bottom padding in globe view, a donut shape appears on the globe, leaking the background color of the page. This only seems to happen with bottom padding and seems to occur when enough of the globe goes outside the viewport.

Screenshot 2023-03-31 at 08 42 09

mapbox-gl-js version: 2.13.0

browser: Tested on Chrome 111, Safari 16 mac & iOS, Firefox 111,

Steps to Trigger Behavior
  1. Set projection to globe
  2. Increase bottom padding until issue appears
Link to Demonstration

https://jsfiddle.net/jhesk35c/

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the globe projection and increasing bottom padding in the linked JSFiddle, checking the behavior in the listed browsers. Trace the globe rendering path responsible for the viewport edge and padding; done means no donut or page-background leak appears when the globe extends beyond the viewport.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.