mapbox / mapbox/mapbox-gl-js

transformRequest is overwritten by defaults for Accept headers

Open
#12,011 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-triaged bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

**mapbox-gl-js version**:
2.8.1

**browser**:
Firefox

### Steps to Trigger Behavior

1. add a transformRequest the sets the "accept" header
2. load the page
3. header isn't set. Other custom headers are set properly, but Accept: is overwritten by the default application/json value

### Expected Behavior

Use the header I explicitly add (I need application/vnd.pgrst.object+json to get data from PostgREST)

### Actual Behavior

Default value is always used.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the TypeScript source for the transformRequest handling and the default Accept header, then reproduce the reported behavior in Firefox using a custom application/vnd.pgrst.object+json value. Done means an explicitly supplied Accept header is preserved while other request headers continue to work.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, networking
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.