mapbox / mapbox/mapbox-gl-js

Markers ignore horizon shift

Open
#11,860 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Markers do not account for horizonShift introduced in #10304

### Steps to Trigger Behavior

1. Map with a marker
2. High zoom and high pitch
3. Pan away from the marker

### Expected Behavior

Marker disappears when above the horizon. (Or alternatively, the marker could lock to the horizon).

### Actual Behavior)

Marker floats above the horizon.

![image](https://user-images.githubusercontent.com/14878684/167178951-bef9a58a-766c-45e7-8567-ae98b4ee226a.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue with a map marker at high zoom and pitch, then trace marker positioning around the horizonShift introduced in #10304. Done means the marker no longer floats above the horizon: it should disappear when above it or lock to the horizon.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.