mapbox / mapbox/mapbox-gl-js

Flaky tests: master ticket

Open
#11,732 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

testing :100:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

This ticket consolidates reports of flaky tests in one place.

### Render tests:

#### render-tests/dynamic-filter/symbols/line/:

- [ ] `render-tests/dynamic-filter/symbols/line/combined-pitch-distance/low-pitch-far-visible`
- [ ] `render-tests/dynamic-filter/symbols/line/combined-pitch-distance/high-pitch-far-hidden` https://github.com/mapbox/mapbox-gl-js/issues/11730
- [ ] `render-tests/dynamic-filter/symbols/line/combined-pitch-distance-data-driven/late-dynamic`
- [ ] `render-tests/dynamic-filter/symbols/line/distance-near-cull` https://github.com/mapbox/mapbox-gl-js/issues/11729
- [ ] `render-tests/dynamic-filter/symbols/line/distance-far-cull`
- [ ] `render-tests/dynamic-filter/symbols/line/distance-near-and-far-cull` https://github.com/mapbox/mapbox-gl-js/issues/11737
- [ ] `render-tests/dynamic-filter/symbols/line/distance-nofilter` https://github.com/mapbox/mapbox-gl-js/issues/11742

#### render-tests/fog/:
- [ ] `fog/terrain/basic` https://github.com/mapbox/mapbox-gl-js/issues/11734
- [ ] `fog/terrain/sky-composition` https://github.com/mapbox/mapbox-gl-js/issues/11669
- [ ] `fog/terrain/equal-range`
- [ ] `fog/disable` https://github.com/mapbox/mapbox-gl-js/issues/11738
- [ ] `fog-reenable`

#### Other render tests:
- [x] https://github.com/mapbox/mapbox-gl-js/issues/11234
- [ ] https://github.com/mapbox/mapbox-gl-js/issues/10314
- [x] https://github.com/mapbox/mapbox-gl-js/issues/8679
- [ ] https://github.com/mapbox/mapbox-gl-js/issues/10181
- [ ] https://github.com/mapbox/mapbox-gl-js/issues/11731

### Query tests:
- [ ] `query-tests/terrain/draped/lines/slope-occlusion` https://github.com/mapbox/mapbox-gl-js/issues/11726 This test alone is responsible for 1/3 of failures.
- [ ] https://github.com/mapbox/mapbox-gl-js/issues/11727
- [ ] https://github.com/mapbox/mapbox-gl-js/issues/11728
- [ ] https://github.com/mapbox/mapbox-gl-js/issues/11735

### Unit tests:

- [ ] test/unit/ui/camera.test.js camera > \#easeTo > duration is 0 when prefers-reduced-motion: reduce is set ([example here](https://app.circleci.com/pipelines/github/mapbox/mapbox-gl-js/11718/workflows/8d7bb490-8b23-4b32-9dcd-c6e32c501094/jobs/155429))
- [ ] test/unit/terrain/terrain.test.js Elevation > map._updateAverageElevation ([example here](https://app.circleci.com/pipelines/github/mapbox/mapbox-gl-js/11535/workflows/8755510b-2fb3-4cc8-b3c4-06242c882df7/jobs/152643))
- [ ] test/unit/ui/map.test.js Map > render stabilizes ([example here](https://app.circleci.com/pipelines/github/mapbox/mapbox-gl-js/12036/workflows/4c2cf32c-15e5-4025-8f5e-d1f6aa2818f3/jobs/160364))

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the listed render-tests, query-tests/terrain/draped/lines/slope-occlusion, and the three unit-test files to identify one reproducible failure. Run the affected test and compare its failure pattern with the linked reports. Done means isolating and fixing a flaky test, then verifying it no longer fails intermittently.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
frontend, testing-qa, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
20/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.