mapbox / mapbox/mapbox-gl-js

Set `fadeDuration = 0` for the initial-load of symbols from a `geojsonSource.setData` call

Open
#11,283 0 comments 1 reaction 1 assignee View on GitHub

@avpeery is already working on this.

Since Nov 17, 2021.

  • #11294 by @avpeery — closed without merging
feature :green_apple:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

One of the problems with animating with `setData` is that `Placement` triggers fade-in and out of symbols that have been updated.
So, instead of a symbol jumping to a new point, depending on timing symbols can fade-out from the old spot and fade-into the new spot.

This JSbin reproduces the issue:
https://jsfiddle.net/arindam1993/dzLvmbqo/18/

We can fix this by temporarily setting fadeDuration to 0 while a `setData` is in flight, just like we do for initial load.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.