mapbox / mapbox/mapbox-gl-js

Add better input validation for projections

Open
#11,251 0 comments 1 reaction 1 assignee View on GitHub

@ryanhamley is already working on this.

Since Nov 5, 2021.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

We should handle projection inputs more completely and make setProjection (or the inputs via the map constructor and style spec) a no-op if input is invalid.

Expected Behavior

Should fail gracefully by being a no-op and throwing a non-breaking error

Actual Behavior

Screen Shot 2021-11-05 at 1 37 45 PM

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.