non-mercator projections add extra vertices when line geometry used in circle layer
Nobody has claimed this yet.
- Dominant language
- TypeScript
- Stars
- 12.4k
- Forks
- 2.4k
- PR merge metrics
- No merged PRs in 30d
Description
Non-mercator projections introduce extra circles when a line geometry is used for a circle layer.
Most commonly users would use Point or MultiPoint geometries with circle layers, but it is possible to use polygon or line geometries. We should disable resampling when we load a geometry that will be used as points.
**mapbox-gl-js version**: v2.6.0 / main
**browser**: all
### Steps to Trigger Behavior
1. open http://localhost:9966/debug/animate.html
2. `map.setProjection('albers')
### Link to Demonstration
http://localhost:9966/debug/animate.html
### Expected Behavior
Vertices drawn only at ends of line. But also draw in the correct projection.
### Actual Behavior
Line's resample vertices are drawn.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the issue in debug/animate.html with map.setProjection('albers'), then trace how line geometry is loaded and resampled for a circle layer. Done means only the line's endpoint vertices are drawn and they appear in the correct non-Mercator projection.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- typescript
- Domain
- computer-graphics, frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100