mapbox / mapbox/mapbox-gl-js

fill-pattern is not seamless with non-mercator projections

Open
#11,221 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

mapbox-gl-js version: main / v2.6.0

browser: all

Steps to Trigger Behavior
  1. open http://localhost:9966/debug/#1.41/0/-16.2
  2. call map.setPaintProperty('water', 'fill-pattern', 'dot-11')
Expected Behavior

pattern is seamless across tile edges

Actual Behavior

Screen Shot 2021-11-04 at 1 24 53 PM


At low zoom levels, before the unskewing kicks in, this is just a matter of getting the world coordinate offset correct for each tile. At high zoom levels, the unskewed coordinate space changes as you pan around which might make the pattern move separately from the map. I'm not sure what the behavior should be. We need some experimentation

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue from the debug URL by calling map.setPaintProperty('water', 'fill-pattern', 'dot-11') and compare non-Mercator views at low and high zoom. Experiment to define the intended high-zoom behavior, then verify that the pattern remains seamless across tile edges without moving separately from the map.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.