mapbox / mapbox/mapbox-gl-js

Terrain: drape map aligned circles

Open
#11,075 1 comment 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

3d :triangular_ruler: bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Similarly to #10365 , we could drape circles that are map aligned (circle-pitch-alignment and circle-pitch-scale == 'map').

With terrain and set `Map.optimizeForTerrain` (set by default) the map will render for performance priority, which may lead to layer reordering allowing to maximize performance (layers that are draped over terrain will be drawn first, including fill, line, background, hillshade and raster). Any circles will be rendered later, with symbols. Supporting draping for map aligned circles, in addition to immediate render, would allow them to be rendered in proper order, regardless if they are within draped or non draped batch of layers.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing issue #10365 and the terrain rendering and layer-ordering behavior described here. Determine how map-aligned circles are currently rendered relative to draped layers and symbols; done means supporting their draping while retaining immediate rendering and correct ordering with terrain optimization enabled.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, performance
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.