mapbox / mapbox/mapbox-gl-js

allow changing Mapbox logo/wordmark location after map initialisation

Open
#10,539 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api :memo: feature :green_apple:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

## Motivation

GL JS allows developers to choose which corner the Mapbox logo/wordmark appears, however this can only be configured once at map initialisation.

When designing a page with a Mapbox map, the developer might which to place the wordmark in one position on wide screens (desktop) and a different position on narrow screens (mobile). Currently that's not easy to achieve.

## Design Alternatives

One option is to provide a setter method for the logo position so it can be altered at any time after map initialisation.

Another option is to make the LogoControl part of the public API, thereby allowing it to be manually added as a control. Developers would then add/remove it to move it into a different corner.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing how the logo position is configured during map initialisation and inspect the mentioned LogoControl implementation. Compare the setter-method and public-control alternatives, then define the API behavior and verify that the logo can move between corners after initialization across responsive layout changes.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.