mapbox / mapbox/mapbox-gl-js

Improve 3D tile cover when tiles are fully within negative elevation

Open
#10,493 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3d :triangular_ruler: bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

When terrain._visibleDemTiles == 0, we may hit a corner case: when there are tiles fully within negative elevation we might miss tiles, because they don't intersect with the frustum (so they are not accounted for in getMinElevationBelowMSL). One approach would be to use with an overly larger frustum for tile cover, to ensure they are marked as visible at least once.

Example location: http://localhost:9966/debug/terrain-debug.html#15.02/31.43313/35.45124/-7.7

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the terrain-debug case at the provided URL and start with the tile-cover logic involving terrain._visibleDemTiles and getMinElevationBelowMSL. Trace how frustum intersection affects negative-elevation tiles; done means fully negative tiles are marked visible at least once and the 3D cover no longer misses them.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.