mapbox / mapbox/mapbox-gl-js

Possible render test regression

Open
#10,473 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs investigation :mag:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

Render test `text-pitch-alignment/viewport-text-depthtest` was found to have a regression that wasn't caught by the test because the pixel difference was below the error threshold value. The test was rebaselined as part of PR https://github.com/mapbox/mapbox-gl-js/pull/10456 but the cause of the regression should be investigated further.

Expected image _before_ rebaselining:
![pre](https://user-images.githubusercontent.com/55925868/110937978-d5e81d00-833b-11eb-8316-e56cc0078a14.png)

Expected image _after_ rebaselining:
![post](https://user-images.githubusercontent.com/55925868/110937973-d41e5980-833b-11eb-8f50-f0c7cafca9d6.png)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the render test `text-pitch-alignment/viewport-text-depthtest` and inspect PR 10456, which rebaselined it. Compare the before- and after-rebaselining images and trace why the pixel difference stayed below the error threshold. Done means the regression's cause is identified and the test no longer misses it.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, testing-qa
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
30/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.