mapbox / mapbox/mapbox-gl-js

Paint properties update in steps when terrain is active

Open
#10,302 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3d :triangular_ruler: bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

### Steps to Trigger Behavior

1. Zoom in and out on a line feature

### Expected Behavior
Without terrain the line maintains `line-width` continuously with zoom
![2020-07-14 20 01 47](https://user-images.githubusercontent.com/1449257/87498557-e7422380-c60c-11ea-89fb-cd35d0121f13.gif)

### Actual Behavior
With terrain enabled `line-width` updates in steps and with an inconsistent time delay.
![2020-07-14 20 06 11](https://user-images.githubusercontent.com/1449257/87498799-8830de80-c60d-11ea-8136-ef5788848420.gif)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

First reproduce the behavior in mapbox-gl-js using a line feature, terrain enabled, and zoom changes, comparing it with terrain disabled. Trace the terrain and line-width rendering entry points to find the delayed stepped update; done means line-width changes continuously and consistently while zooming with terrain active.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript, typescript
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.