mapbox / mapbox/mapbox-gl-js

Geolocate control doesn't drape right with terrain and high pitch

Open
#10,274 2 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug :lady_beetle: GL native → GL JS
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

The geolocate control's accuracy circle isn't projected correctly at high pitch+zoom. It should remain attached to the surface. The accuracy circle needs to be rethought for instances when the geolocation is on a hill/slope.

![image](https://user-images.githubusercontent.com/11619675/81523884-1afa8780-9304-11ea-906d-fce4a3745051.png)

![image](https://user-images.githubusercontent.com/11619675/81523972-7167c600-9304-11ea-9d80-3bdfd393189c.png)

This will eventually impact the various Mobile/Nav pucks as well.

cc @mapbox/mobile @d-prukop @avi-c

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start from the geolocate control and reproduce the accuracy-circle projection with terrain enabled at high pitch and zoom, using the examples shown in the issue. Investigate how the circle is attached to the map surface on hills and slopes. Done means the circle remains correctly draped on the terrain; consider the noted future impact on Mobile/Nav pucks.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.