mapbox / mapbox/mapbox-gl-js

height offsetting for circles, symbols, fill-extrusions fails based on maxzoom

Open
#10,265 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

3d :triangular_ruler: bug :lady_beetle:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

When a vector source has maxzoom < terrain max zoom. The height offsetting logic fails and all vector layers znap to 0 as soon as a zoom threshold value is crossed

![2020-06-23 16 45 35](https://user-images.githubusercontent.com/1449257/85478399-00f1cd00-b571-11ea-8915-c94b2b9493d3.gif)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure with a vector source whose maxzoom is below the terrain max zoom, then trace the height-offsetting logic for circles, symbols, and fill-extrusions across the zoom threshold. Done means these vector layers retain their terrain height offset instead of snapping to zero.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
computer-graphics
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.