mapbox / mapbox/mapbox-gl-js

Exiting full screen mode changes the viewport

Open
#10,011 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

needs discussion :speech_balloon:
Dominant language
TypeScript
Stars
12.4k
Forks
2.4k
PR merge metrics
No merged PRs in 30d

Description

**mapbox-gl-js version**: 1.12.0

**browser**: Chrome 85

### Steps to Trigger Behavior

1. Just enter and exit the full screen mode.

### Link to Demonstration

https://jsfiddle.net/j2mw8n7g/

### Expected Behavior

When I exit full screen mode, I expect the viewport to be the same as before.

### Actual Behavior

When I exit full screen mode, the viewport is not the same anymore.

This behavior seems to be there only with the zoom at 0.
I have no idea where the problem may come from and if this behavior is intentional or if it is a bug.

Thank you very much !
Florian

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by running the linked JSFiddle in Chrome 85 and reproduce the behavior at zoom 0, recording the viewport before entering full screen and after exiting. Trace the mapbox-gl-js handling involved in full-screen transitions and viewport changes; done means exiting full screen preserves the original viewport.

Written by the indexing model from the issue text.

Assessment

Tech stack
typescript
Domain
frontend, web-dev
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.