mapbox / mapbox/mapbox-gl-geocoder
Potential `null` dereference in `onRemove()`
Open
Nobody has claimed this yet.
auto-triaged
bug
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
It's possible that `parentNode` is `null`, which causes a null dereference:
https://github.com/mapbox/mapbox-gl-geocoder/blob/5ac5826bd8e51fd6219bb269a4cc2bba0ac4902d/lib/index.js#L395
This can occur if the geocoder adds itself to a map, then `map.remove()` is called, and then the geocoder tries to remove itself from the map.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in lib/index.js around line 395 and inspect onRemove() with the reported sequence: add the geocoder to a map, call map.remove(), then remove the geocoder. Reproduce the null parentNode case and verify that onRemove() completes without a null dereference.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 55/100