mapbox / mapbox/mapbox-gl-geocoder
ECMAScript module
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
Hi everyone,
are you planning to convert commonJS modules to ECMAScript modules? I keep getting this error below. for now, I have the workaround "allowedCommonJsDependencies": ["@mapbox/mapbox-gl-geocoder"]. But it can be nice to have ES module.
@mapbox/mapbox-gl-geocoder'. CommonJS or AMD dependencies can cause optimization bailouts.
For more info see: https://angular.io/guide/build#configuring-commonjs-dependencies
Thanks very much for all your time and work on this plugin, it is very nice and helpful
Best
Hmendezm
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing how the package currently publishes CommonJS modules and how Angular reports @mapbox/mapbox-gl-geocoder as a dependency. Define the expected ECMAScript module output and verify that the plugin remains usable with mapbox-gl-js; the issue names no files or tests, so the completion criteria need clarification.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100