mapbox / mapbox/mapbox-gl-geocoder
Clarify/rework "localGeocoderOnly" option wrt external geocoder
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
So, there are now three potential sources of geocoder results: Mapbox, local, custom external.
There is one flag to switch off Mapbox and only use local. (Implicitly, if `localGeocoder` or `externalGeocoder` is undefined, they won't be used. ) But there doesn't seem to be a way to have:
- only external results
- external plus local results
Could I suggest maybe renaming `localGeocoderOnly` to `useMapbox`, defaulting to true? Or some other option where not using Mapbox is not coupled to also using local results, and not external results.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Trace how the localGeocoderOnly option controls Mapbox, local, and custom external results, including its public documentation and tests if present. Define the supported combinations before changing the option, then verify that only external, local plus external, and existing Mapbox behavior are covered and documented.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100