mapbox / mapbox/mapbox-gl-geocoder
keydown triggers when tapping result
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
i don't want to reopen the results when a result is tapped.
i'm not sure why this is happening on my mobile, but i disabled the keydown listener since i'm not using it anyway.
```
export default class Geocoder extends MapboxGeocoder {
onAdd(...args) {
const addEventListener = EventTarget.prototype.addEventListener;
EventTarget.prototype.addEventListener = function (type, ...args) {
if (type !== 'keydown') {
// the debouncing causes the options to open when a result is tapped
addEventListener.call(this, type, ...args);
}
};
const el = super.onAdd(...args);
EventTarget.prototype.addEventListener = addEventListener;
return el;
}
}
```
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Geocoder.onAdd entry point and inspect how the keydown listener and result-tap handling interact, including the debouncing mentioned in the report. Reproduce the mobile behavior described in the issue, then verify that tapping a result does not reopen the results.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100