mapbox / mapbox/mapbox-gl-geocoder

keydown triggers when tapping result

Open
#378 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-triaged bug
Dominant language
JavaScript
Stars
388
Forks
181
PR merge metrics
No merged PRs in 30d

Description

i don't want to reopen the results when a result is tapped.

i'm not sure why this is happening on my mobile, but i disabled the keydown listener since i'm not using it anyway.

```
export default class Geocoder extends MapboxGeocoder {
onAdd(...args) {
const addEventListener = EventTarget.prototype.addEventListener;
EventTarget.prototype.addEventListener = function (type, ...args) {
if (type !== 'keydown') {
// the debouncing causes the options to open when a result is tapped
addEventListener.call(this, type, ...args);
}
};
const el = super.onAdd(...args);
EventTarget.prototype.addEventListener = addEventListener;

return el;
}
}
```

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start at the Geocoder.onAdd entry point and inspect how the keydown listener and result-tap handling interact, including the debouncing mentioned in the report. Reproduce the mobile behavior described in the issue, then verify that tapping a result does not reopen the results.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.