mapbox / mapbox/mapbox-gl-geocoder

Transpilation / IE11 Support

Open
#367 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

enhancement
Dominant language
JavaScript
Stars
388
Forks
181
PR merge metrics
No merged PRs in 30d

Description

I've noticed an issue in IE11 whereby the geocoder won't load unless polyfills exist for all the missing APIs which exist in it.

It's worth noting that Mapbox GL itself is transpiled correctly for this scenario.

Rather than relying on consumers of my component to polyfill their site, it might be worth addressing these issues.

I believe the exact error is from the Object.values/entries Array.from/.forEach family, but I don't know for sure due to the minification.

Is there a notion of browser-support with this library?

Screenshot from 2020-06-20 10-13-19

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

No source file or test is named. Start by reproducing the geocoder load failure in IE11 and inspect the transpilation and browser-support configuration, focusing on the suspected Object.values/entries, Array.from, and Array.prototype.forEach APIs. Done means the geocoder loads in IE11 without requiring consumers to provide the missing polyfills.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
build-system, frontend
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.