mapbox / mapbox/mapbox-gl-geocoder
Show clear icon if no results
Open
Nobody has claimed this yet.
enhancement
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
Right now, if there are no results, the clear icon disappears:
Which seems weird – this is maybe the case where I'm _most likely_ to want to use a clear icon.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No files or tests are identified. Start by reproducing a search with no results and tracing the geocoder control's clear-icon rendering; then add coverage for that state. Done means the clear icon remains visible when results are empty and still clears the current search.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100