mapbox / mapbox/mapbox-gl-geocoder
Check for invalid characters
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 388
- Forks
- 181
- PR merge metrics
- No merged PRs in 30d
Description
Currently, invalid (?) characters (`***` for example) in user queries throw an error when they get regex'd. These types of queries don’t trigger an error in the geocoding API, but they do trip up a regular expression in the plugin itself.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the plugin's user-query handling where input is passed to a regular expression; no file or test is named in the issue. Reproduce the failure with a query such as `***`, then verify that invalid characters no longer throw and that the query still reaches the geocoding API.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- search
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100