mapbox / mapbox/mapbox-gl-draw
Pass userProperties to midpoints and vertices
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 612
- Avg merge
- 8d 9h
- Merged PRs (30d)
- 5
Description
On creation of a midpoint or a vertex, the new feature is initialized with a reference to the parent feature but none of the properties are passed down. This means that midpoints and vertices can't be styled based on user-provided properties. I'd like to work up a PR where the user-provided properties are passed down to these features for potential styling. Thoughts?
Parent references:
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/lib/create_vertex.js and src/lib/create_midpoint.js at the linked lines, then trace how parent feature properties are represented and consumed for styling. Verify the creation paths for both feature types and confirm that user-provided properties are available on the resulting midpoint and vertex features.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 50/100