mapbox / mapbox/mapbox-gl-draw
Uncaught TypeError `i.onCombineFeatures is not a function` when nothing is drawn
Open
Nobody has claimed this yet.
bug
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 612
- Avg merge
- 8d 9h
- Merged PRs (30d)
- 5
Description
### Steps to Trigger Behavior
1. Go here: https://jsfiddle.net/ymj8vwpe/
2. Click the combine button when there is nothing drawn or selected
### Expected Behavior
No uncaught error in console
### Actual Behavior
Uncaught TypeError in console: `i.onCombineFeatures is not a function`
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Reproduce the error using the linked JSFiddle and the combine button with nothing drawn or selected. Trace the combine action and the `onCombineFeatures` call, then verify that the empty-state interaction completes without an uncaught console error.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100