mapbox / mapbox/mapbox-gl-draw
Upgrade to newer JSDom
Open
@mourner is already working on this.
Since Aug 31, 2022.
build
- Dominant language
- JavaScript
- Stars
- 1.1k
- Forks
- 612
- Avg merge
- 8d 9h
- Merged PRs (30d)
- 5
Description
Current we depend on an old `mock-browser` package for mocking window/document and HTML elements in Node for unit tests, and that package depends on an old JSDom version (v9). We should upgrade directly to the latest JSDom dependency (v20) and use it to avoid depending on an old package, however, upgrading to the latest version breaks 14 tests for no clear reason. Capturing in ticket to investigate later.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.