mapbox / mapbox/mapbox-gl-directions

mapbox-gl-directions CSS breaks mapbox-gl-geocoder CSS

Open
#252 2 comments 5 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

auto-triaged bug
Dominant language
JavaScript
Stars
255
Forks
130
PR merge metrics
No merged PRs in 30d

Description

```
import MapboxGeocoder from '@mapbox/mapbox-gl-geocoder'
import '@mapbox/mapbox-gl-geocoder/dist/mapbox-gl-geocoder.css'
import MapboxDirections from '@mapbox/mapbox-gl-directions/dist/mapbox-gl-directions'
import '@mapbox/mapbox-gl-directions/dist/mapbox-gl-directions.css'
```
mapbox-gl-directions CSS breaks mapbox-gl-geocoder CSS, since it overwrites the geocoder styles (it shouldn't, by design; we wouldn't have this problem now)

Wasted half an hour on this, to discover now it's a known issue since last year:
https://github.com/mapbox/mapbox-gl-directions/pull/226

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Reproduce the issue using the two imported stylesheets shown in the report, then inspect the generated mapbox-gl-directions and mapbox-gl-geocoder CSS for overlapping selectors. Use pull request #226 as the existing context; done means loading both stylesheets no longer causes the directions CSS to overwrite geocoder styles.

Written by the indexing model from the issue text.

Assessment

Tech stack
css, javascript
Domain
frontend
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.