mapbox / mapbox/mapbox-gestures-android
Refactor value animators
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 30
- Forks
- 23
- PR merge metrics
- No merged PRs in 30d
Description
The main idea for the refactor is to make value animator for a compatible gesture independent from its state. Value animation calculations and callbacks will happen only when requested. This means that gestures will be flagged as `not in progress` during the animation that happens after a gesture which shouldn't be a huge trade-off for more flexibility and better performance if a user doesn't want to use provided animations.
Progress
- [x] remove current ValueAnimators implementation (#16)
- [ ] add new optional implementation that does calculations and handles Animators
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the issue's completed removal of the current ValueAnimators implementation and the remaining unchecked requirement. The new optional implementation should calculate values and handle Animators only when requested, while allowing gestures to be marked not in progress during post-gesture animation. Done means this implementation is available without requiring provided animations.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- mobile-dev
- Issue type
- Refactor
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100