mapbox / mapbox/makizushi

Support base type of circle

Open
#13 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
JavaScript
Stars
24
Forks
15
PR merge metrics
No merged PRs in 30d

Description

Currently the only parameter for the base option is `"pin"`. It would be great if there was also the option for a `"circle"`. I could also see use for other shapes as well but circle is the most obvious need.

If I create this and submit a pull request would you consider accepting and merging into the master branch?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the implementation of the `base` option and the existing `"pin"` handling in the repository. Trace how base shapes are selected, then add support for `"circle"` and verify that markers using this option render correctly alongside the existing pin behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.