SVG props optimization
@Udobnyj is already working on this.
Since Jun 1, 2022.
- Dominant language
- JavaScript
- Stars
- 1.6k
- Forks
- 210
- PR merge metrics
- No merged PRs in 30d
Description
### What is the problem?
I started to understand how our Maki library works (while creating a direct export to Git from Figma), and I ran into our strange optimizing SVG process.
We have [format-icons.js](https://github.com/mapbox/maki/blob/main/scripts/format-icons.js) which is responsible for the optimization of SVG.
And it has a list of allowed props:
And I have questions about this list. Why do we still have props like `version`, and `xmlns`, because they are so old? Do we need them for backward compatibility?
Same question about our `` part which stores information about the `version` and `encoding`.
In the end, the SVGs that are stored in our library now look like this.
And they can look like this and work exactly the same
### Proposed solution
I can refine the SVG optimization script and make our icons more modern
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.