Base64 icon doesn't work in FireFox (54.0)
Open
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 380
- Forks
- 140
- PR merge metrics
- No merged PRs in 30d
Description
See this comment: https://github.com/mapbox/leaflet-image/commit/d06a02a7ef7691d8d9fbac61b36b6f96623e5526#commitcomment-22683002
I think the onload function is being called too early and before the job is done.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the linked commit comment and trace the Base64 icon's onload handling in the image-generation path. Reproduce the issue in Firefox 54.0, then verify that the callback waits until the icon work is complete and the icon renders correctly.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100