Simply ignore Leaflet.label?
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 380
- Forks
- 140
- PR merge metrics
- No merged PRs in 30d
Description
Sorry for raising an issue that is more a query:
Is there no way to fork the image generation so that it simply ignores L.divIcon without marker._icon.src values? My reason for asking - image generation bombs completely but ONLY when labels are included (which i assume results from the inclusion of syntax in leaflet-image.js that is unable to detect validly formed elements due to assumptions cast on objects present, i.e. a particular element is assumed to contain a .src attribute when it does not, i.i.e assumed property/attribute values - no detection or testing for assumed properties)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in leaflet-image.js and trace image generation when labels use L.divIcon and marker._icon lacks a src value. Reproduce the failure with labels enabled, then determine the intended handling for such markers; done means image generation no longer fails for that case and the relevant behavior is covered by a test if the repository provides one.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100