Raise exception on CORS error
Nobody has claimed this yet.
- Dominant language
- JavaScript
- Stars
- 380
- Forks
- 140
- PR merge metrics
- No merged PRs in 30d
Description
If there is a CORS error, leaflet-image does not raise an exception. Hence, there is no console indication that there is an issue.
This makes problems with CORS rather difficult to debug, as there is no error output to indicate what is going wrong. Specifically, it is missing from handleMarkerLayer and handleEsriDynamicLayer.
As the default CDN for Leaflet.js (cdnjs) doesn't seem to have CORS headers enabled, this should really be an important feature.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by locating handleMarkerLayer and handleEsriDynamicLayer, the two paths named in the issue, and reproduce a CORS failure with a resource lacking CORS headers. Done means both paths raise an exception or otherwise produce visible error output when CORS prevents the image operation.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- javascript
- Domain
- frontend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 45/100