mapbox / mapbox/hpp-skel

Get minimum required Cmake version correct

Open
#66 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
CMake
Stars
116
Forks
18
PR merge metrics
No merged PRs in 30d

Description

In the `CMakeLists.txt` we have:

```
cmake_minimum_required(VERSION 3.8)
```

But we've never verified that 3.8 is actually needed for the features used in the `CMakeLists.txt`. Ideally if we don't use features requiring 3.8 we could drop this version down to make it less likely a developer would need to upgrade `cmake` on their system.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Review CMakeLists.txt and identify which commands and options determine the minimum required CMake version. Verify the lowest compatible version against the features used, then update the requirement if appropriate and confirm the project still configures successfully with that version.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake
Domain
build-system
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.